This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [rfc] [patch] more 'long' in the hypervisor interface

To: Hollis Blanchard <hollisb@xxxxxxxxxx>
Subject: Re: [Xen-devel] [rfc] [patch] more 'long' in the hypervisor interface
From: Chris Wright <chrisw@xxxxxxxxxxxx>
Date: Wed, 28 Jun 2006 14:09:48 -0700
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 28 Jun 2006 14:10:23 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1151528600.11374.75.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1151528600.11374.75.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/
* Hollis Blanchard (hollisb@xxxxxxxxxx) wrote:
> Hi Keir, we've come across some more users of 'long' in the hypervisor
> interface: xen/include/public/memory.h. Unlike the dom0_ops, we can't
> just change these to be 64 bits because 32-bit kernels use these
> structures for the balloon driver.
> I would like to create a new type, say "legacy_ulong_t", to cover these
> cases and future instances we'll undoubtedly come across. What do you
> think?
> Signed-off-by: Hollis Blanchard <hollisb@xxxxxxxxxx>
> diff -r 10db0f8c710d xen/include/public/arch-x86_64.h
> --- a/xen/include/public/arch-x86_64.h        Wed Jun 28 15:37:45 2006 -0400
> +++ b/xen/include/public/arch-x86_64.h        Wed Jun 28 16:02:21 2006 -0500
> @@ -104,6 +104,8 @@ DEFINE_XEN_GUEST_HANDLE(xen_pfn_t);
>  #define MAX_VIRT_CPUS 32
>  #ifndef __ASSEMBLY__
> +
> +typedef unsigned long legacy_ulong_t;

What is legacy about it, this looks quite odd, and I don't think will
build on i386.


Xen-devel mailing list