Re: [XenPPC] [rfc] [patch] 64-bitize guest handles

[Jimi Xenidis <jimix@xxxxxxxxxxxxxx>]

I think you'll like this.

On Jun 27, 2006, at 4:59 PM, Hollis Blanchard wrote:
>  #define __DEFINE_XEN_GUEST_HANDLE(name, type) \
> -    typedef struct { type *p; } __guest_handle_ ## name
> +    typedef union { unsigned long long l; type *p; }  
> __guest_handle_ ## name
how about:
     struct __guest_handle_struct {
         char __pad[sizeof (long) - sizeof (void *)];
         type *p;
     } __attribute__((__aligned__(8)));
 #define __DEFINE_XEN_GUEST_HANDLE(name, type) \
     typedef struct __guest_handle_struct __guest_handle_ ## name

That way no matter who which ABI reads it 'p' is "correct" then, I  
think, the rest of the diff can go.
-JX

_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel