Re: [XenPPC] [RFC] fix stupid grant table flags

[Hollis Blanchard <hollisb@xxxxxxxxxx>]

On Wed, 2006-06-21 at 18:49 -0400, Jimi Xenidis wrote:
> 
>    static inline void  clear_entry_flag(unsigned long nr, volatile  
> uint16_t *addr) {
>        volatile unsigned long *laddr;
>        unsigned long lnr;
>    #ifdef SAFETY_DANCE
>        BUG_ON((ulong)addr % sizeof (ulong));
>    #endif
>        lnr = (BITS_PER_LONG - (sizeof (*addr) * 8)) + nr;
>        laddr = (volatile unsigned long *)addr;
>        clear_bit(lnr, laddr);
>    } 

Why all the "volatile" here? This function isn't dereferencing those
pointers, so it shouldn't matter?

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel