This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [patch] ACM ops interface

To: Reiner Sailer <sailer@xxxxxxxxxx>
Subject: [Xen-devel] Re: [patch] ACM ops interface
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Thu, 08 Jun 2006 13:32:51 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 08 Jun 2006 11:32:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <OF37D5CB81.C5EAFC13-ON85257187.00638862-85257187.0064853E@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <OF37D5CB81.C5EAFC13-ON85257187.00638862-85257187.0064853E@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2006-06-08 at 14:17 -0400, Reiner Sailer wrote:
> > First, it isn't using XEN_GUEST_HANDLEs where it should (i.e. when
> using
> > pointers in the interface). What's a little scary is that because
> it's
> > using void* everywhere, we didn't get any compiler warnings (if
> you're
> > passing buffers, maybe 'unsigned char *' would be a better type?). 
> Keir responded to this point already 

I didn't see that, actually.

Hollis Blanchard
IBM Linux Technology Center

Xen-devel mailing list