WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

Re: [XenPPC] [pushed] [ppc] fix open pic initalization for g5.

To: jimix@xxxxxxxxxxxxxx
Subject: Re: [XenPPC] [pushed] [ppc] fix open pic initalization for g5.
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Mon, 22 May 2006 15:30:31 -0500
Cc: xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 22 May 2006 13:29:50 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <E1FiGhl-00018R-M8@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <E1FiGhl-00018R-M8@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx
static int find_mpic(void)
{
    ...
    rc = find_mpic_simple_probe(oft_p);

    if (rc < 0) {
        DBG("%s: Searching for pic ...\n", __func__);
        rc = find_mpic_canonical_probe(oft_p);
    }

    return rc;
}

Aside from some stylistic issues around 'opic_flags', why do we even
have two paths here? If the "canonical" probe always works, let's always
use it.

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel

<Prev in Thread] Current Thread [Next in Thread>