WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

[XenPPC] [PATCH] fix open pic initalization for g5

To: xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Subject: [XenPPC] [PATCH] fix open pic initalization for g5
From: Maria Butrico <butrico@xxxxxxxxxxxxxx>
Date: Mon, 22 May 2006 15:37:58 -0400
Delivery-date: Mon, 22 May 2006 12:38:30 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx
Signed-off-by: Maria Butrico <butrico@xxxxxxxxxxxxxx>

summary:    fix open pic initalization for g5.

        Initialization of open pic should not, by default, use the
        broken u3 flag.  Currently the flag is set for those
        platform where initializitng with this flag does not break.
        On g5's this flag should not be set.

        Other minor cleanup.

diff -r a0fa2ce45bae xen/arch/ppc/mpic_init.c
--- a/xen/arch/ppc/mpic_init.c  Mon May 22 11:01:31 2006 -0400
+++ b/xen/arch/ppc/mpic_init.c  Mon May 22 15:33:18 2006 -0400
@@ -9,15 +9,8 @@
 #include "oftree.h"
 
 #undef DEBUG
-#undef NOSERIAL
 #ifdef DEBUG
-#ifdef NOSERIAL
-int of_printf(const char *fmt, ...)
-    __attribute__ ((format (printf, 1, 2)));
-#define DBG(fmt...) of_printf(fmt)
-#else
 #define DBG(fmt...) printk(fmt)
-#endif  /* #ifdef NOSERIAL */
 #else
 #define DBG(fmt...)
 #endif
@@ -234,7 +227,7 @@ static int find_mpic_simple_probe(void *
     }
     DBG("%s: found OpenPIC at: 0x%lx\n", __func__, opic_addr);
     /* we did not really find the pic device, only its address. 
-     * We use big endian by default
+     * We use big endian andd broken u3 by default.
      */
     opic_flags |= MPIC_BIG_ENDIAN | MPIC_BROKEN_U3;
     return 0;
@@ -339,7 +332,7 @@ struct hw_interrupt_type *xen_mpic_init(
 
     mpic = mpic_alloc(opic_addr,
                       MPIC_PRIMARY |
-                      MPIC_BROKEN_U3 | MPIC_WANTS_RESET |
+                      MPIC_WANTS_RESET |
                       opic_flags,
                       isu_size, irq_offset, irq_count,
                       ipi_offset, senses, senses_count, "Xen-U3-MPIC");

_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [XenPPC] [PATCH] fix open pic initalization for g5, Maria Butrico <=