WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

[XenPPC] [patch] all UART parameters should be unsigned.

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [XenPPC] [patch] all UART parameters should be unsigned.
From: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
Date: Tue, 28 Mar 2006 10:13:29 -0500
Cc: xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 28 Mar 2006 15:14:44 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx
A signed baud results in a huge timeout if baud == BAUD_AUTO which is -1.
There is no reason for any of uart members to be signed.
Signed-off-by: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
---
diff -r 7cdae181971d xen/drivers/char/ns16550.c
--- a/xen/drivers/char/ns16550.c        Mon Mar 27 16:52:31 2006 -0500
+++ b/xen/drivers/char/ns16550.c        Tue Mar 28 10:11:57 2006 -0500
@@ -27,7 +27,7 @@ string_param("com2", opt_com2);
string_param("com2", opt_com2);
static struct ns16550 {
-    int baud, data_bits, parity, stop_bits, irq;
+    unsigned int baud, data_bits, parity, stop_bits, irq;
unsigned long io_base; /* I/O port or memory-mapped I/O address. */ char *remapped_io_base; /* Remapped virtual address of mmap I/ O. */
     /* UART with IRQ line: interrupt-driven I/O. */


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [XenPPC] [patch] all UART parameters should be unsigned., Jimi Xenidis <=