|
xen-merge
RE: [Xen-merge] CONFIG_XEN vs. CONFIG_X86{,_64}_XEN
> It'd be interesting, if it doesn't take you too much time. I'd have
> wanted to rather make this a conditional like
Looks like my memory was faulty... I was just
recalling the attached message. The double
conditional is probably a better choice for
common files.
Dan
P.S. James -- It looks like the xen-merge archives
have had the same problem as xen-ia64-devel archives.
(I had to dig up this message from my personal
email archives.)
> -----Original Message-----
> From: Magenheimer, Dan (HP Labs Fort Collins)
> Sent: Friday, August 12, 2005 10:57 AM
> To: 'Vincent Hanquez'
> Cc: xen-merge@xxxxxxxxxxxxxxxxxxx
> Subject: RE: [Xen-merge] CONFIG_XEN (and more?)
>
> > CONFIG_XEN is suppose to be ARCH-agnostic
> > CONFIG_X86_XEN is for i386-xen
>
> Perfect! Thanks!
>
> Perhaps the CONFIG_X86_XEN designation should start appearing
> in the -sparse trees?. I'm hoping to start merging Xen/ia64
> changes into the -sparse trees at some point and it
> doesn't require any patches outside of arch/ia64, asm-ia64,
> and of course the xen common directories (drivers/xen, etc).
>
> If the Xen/x86-required changes to linux common files
> (include/linux/highmem.h for example) are ifdef'd,
> then other architectures can use the same mkbuildtree.
>
> Dan
>
> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxxxx]
> Sent: Wednesday, December 21, 2005 10:20 AM
> To: Magenheimer, Dan (HP Labs Fort Collins)
> Cc: xen-merge@xxxxxxxxxxxxxxxxxxx
> Subject: RE: [Xen-merge] CONFIG_XEN vs. CONFIG_X86{,_64}_XEN
>
> >CONFIG_XEN should be used whenever the change applies
> >to Xen for all architectures. CONFIG_X86_XEN should be used
> >in generic code when a change applies only to x86.
> >(There was a recent example of this... I can dig it up
> >if you wish.)
>
> It'd be interesting, if it doesn't take you too much time. I'd have
> wanted to rather make this a conditional like
>
> #if defined(CONFIG_XEN) && defined(CONFIG_X86)
>
> as I expect this to be rare.
>
> >If the code is clearly x86-specific
> >(e.g. in arch/i386 or include/asm-x86), I agree the
> >_X86_ part is superfluous.
>
> Sure. But I'd like this to be consistent, which is why, for
> now, I used
> CONFIG_X86_XEN everywhere.
>
> Jan
>
_______________________________________________
Xen-merge mailing list
Xen-merge@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-merge
|
|
|
Home