WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-merge

Re: [Xen-merge] io_apic.c, part 1

To: "Martin J. Bligh" <mbligh@xxxxxxxxxx>
Subject: Re: [Xen-merge] io_apic.c, part 1
From: Andi Kleen <ak@xxxxxxx>
Date: Mon, 8 Aug 2005 17:53:28 +0200
Cc: xen-merge <xen-merge@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 08 Aug 2005 15:51:35 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <416790000.1123515818@[10.10.2.4]>
List-help: <mailto:xen-merge-request@lists.xensource.com?subject=help>
List-id: xen-merge <xen-merge.lists.xensource.com>
List-post: <mailto:xen-merge@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-merge>, <mailto:xen-merge-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-merge>, <mailto:xen-merge-request@lists.xensource.com?subject=unsubscribe>
References: <416790000.1123515818@[10.10.2.4]>
Sender: xen-merge-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, Aug 08, 2005 at 08:43:38AM -0700, Martin J. Bligh wrote:
> This just shoves some ifdef wrappers around whole functions to
> either not define them, or provide a no-op function instead.
> The alternative to this is to split the file, but I tried that,
> and it made an unholy mess. Plus it's much nicer for maintainance
> to keep the alternative definitions right next to each other, if
> it's this trivial.

I would prefer to just replace apic.c/io_apic.c completely with new
files in the Xen case and perhaps factor the still needed functions out.
That's much better than ifdef mess and apic/io_apic needed some
cleanup anyways.

-Andi

_______________________________________________
Xen-merge mailing list
Xen-merge@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-merge

<Prev in Thread] Current Thread [Next in Thread>