RE: [Xen-merge] General xen question on send_IPI_self

["Ian Pratt" <m+Ian.Pratt@xxxxxxxxxxxx>]

> This looks dangerous to me, instintively, though I don't know 
> what you're doing in this space, or why. How can you get away 
> with a no-op for send_IPI_self?
> 
> #ifndef CONFIG_SMP
> void fastcall send_IPI_self(int vector)
> {
> #ifndef CONFIG_XEN
>         unsigned int cfg;
> 
>         /*
>          * Wait for idle.
>          */
>         apic_wait_icr_idle();
>         cfg = APIC_DM_FIXED | APIC_DEST_SELF | vector | 
> APIC_DEST_LOGICAL;
>         /*
>          * Send the IPI. The write to APIC_ICR fires this off.
>          */
>         apic_write_around(APIC_ICR, cfg); #endif } #endif /* 
> !CONFIG_SMP */

send_IPI_self is used only by hw_resend_irq(), which is not required for
our virtualised interrupts. send_IPI_self() was virtualised properly in
smp.c, but I guess someone didn't bother for io_apic.c, since it's not
used anyway.

Ian


_______________________________________________
Xen-merge mailing list
Xen-merge@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-merge