WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

[Xen-ia64-devel] [patch] IA64: request_irq_vector() Return an error if s

To: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-ia64-devel] [patch] IA64: request_irq_vector() Return an error if setup_vector() fails
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Tue, 24 Feb 2009 13:12:07 +1100
Cc: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Delivery-date: Mon, 23 Feb 2009 18:12:12 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
This is consistent with the x86 version of this function.

Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>

--- 

Compile-tested only.

Index: xen-unstable.hg/xen/arch/ia64/linux-xen/irq_ia64.c
===================================================================
--- xen-unstable.hg.orig/xen/arch/ia64/linux-xen/irq_ia64.c     2009-02-24 
09:11:25.000000000 +1100
+++ xen-unstable.hg/xen/arch/ia64/linux-xen/irq_ia64.c  2009-02-24 
13:08:42.000000000 +1100
@@ -243,7 +243,7 @@ static struct irqaction ipi_irqaction = 
 #endif
 
 #ifdef XEN
-extern void setup_vector (unsigned int vec, struct irqaction *action);
+extern int setup_vector (unsigned int vec, struct irqaction *action);
 #endif
 
 void
@@ -276,7 +276,7 @@ int request_irq_vector(unsigned int vect
                unsigned long irqflags, const char * devname, void *dev_id)
 {
        struct irqaction * action;
-       int retval=0;
+       int retval;
 
        /*
         * Sanity-check: shared interrupts must pass in a real dev-ID,
@@ -295,7 +295,8 @@ int request_irq_vector(unsigned int vect
        action->handler = handler;
        action->name = devname;
        action->dev_id = dev_id;
-       setup_vector(vector, action);
+
+       retval = setup_vector(vector, action);
        if (retval)
                xfree(action);
 

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-ia64-devel] [patch] IA64: request_irq_vector() Return an error if setup_vector() fails, Simon Horman <=