[Xen-ia64-devel] Re: [PATCH 00/15] ia64/pv_ops take 5

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

On Fri, May 16, 2008 at 05:06:21PM -0700, Luck, Tony wrote:
> I started looking at this patch set.

Thank you for your time.


> Parts 1-9 applied ok, but part10 (entry.S) failed to apply because of
> recent changes to this file to fix the problems with warnings when
> trying to get locks with interrupts blocked.
> 
> I thought this would be a good point to test the bisectability
> of this patch set and started a build with just parts 1-9 applied.
> The build was perfectly clean, but the kernel hung during boot
> (possibly when first trying to run user processes by the look
> of the last few messages on the console.

I'll rebase/debug the patches and resend them.
My native case test is done under Xen HVM(full virtualized)
domain.


> The code with parts 1-9 applied still looks readable, but I
> think we may need some documentation later to help with maintainability.

I'll write it. It will be under linux-2.6/Documentation/ia64/.

  
> Perhaps even a tool that can check to make sure people don't add
> direct uses of instructions to .S files that need to be
> paravirtualized.

Yes, I also really want such a tool and I've thought of it.
I want to prevent people from accidently breaking paravirtualization
and only a way to do so would be by enforcing.
I think it can be easily achived by CPP macro trick.
At worst a simple .s (or .o) parser.

-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel