WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [PATCH][3/3] Steal time accounting forPVdomain/IA64

To: Atsushi SAKAI <sakaia@xxxxxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] [PATCH][3/3] Steal time accounting forPVdomain/IA64 TAKE2
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Thu, 15 May 2008 18:10:32 +0900
Cc: Aron Griffis <aron@xxxxxx>, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 15 May 2008 02:10:49 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200805150902.m4F92AgY007779@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20080515065619.GG26415%yamahata@xxxxxxxxxxxxx> <200805150902.m4F92AgY007779@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.6i
On Thu, May 15, 2008 at 06:02:00PM +0900, Atsushi SAKAI wrote:

> consider_steal_time() treats stolentick.
> The stolentick is composed of l->itm_delta + alpha.
> The stolentick can consider the large value(unsigned long).
> So stolentick can take from 0 to unsigned long.
> In this meaning, the value of alpha has no assumption in it.

But consider_stea_time() also sets l->itm_next!
Do you agree that l->itm_next can happen to be smaller than
ia64_get_itc() - l->itm_delta?


> As you suggested, if we consider the case of manu vcpu on one pcpu,
> the alpha value expected to become large value.
> But no problem in it.

Why no probelem?
l->itm_next can become smaller than ia64_get_itc() - l->itm_delta.
It breaks the the assumption of timer_interrupts().

-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel