Re: [Xen-ia64-devel] ia64: Fix build problem when VHPT_ENABLED isn't defined

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

Hi Simon-san.

VHPT_ENABLED is directly defined in xen/include/asm-ia64/vhpt.h
as "#define VHPT_ENABLED 1"
Thus your patch causes compilation error like the followings.
I guess you need this options for debugging kexec/kdump and 
that this option is efficient for vhpt related debugging.
So it's worth while to keep vhpt_enabled option, I suppose.

Could you define it ?CFLAGS += -DVHPT_ENABLED) in
xen/arch/ia64/Rules.mk like other options with default y and
remove the define in vhpt.h?



ia64-linux-gnu-ld -g -T xen.lds.s -N \
                -Map map.out linux-xen/head.o
/home/yamahata/xen/ia64/xenbits/my01/xen-unstable.hg/xen/common/built_in.o
/home/yamahata/xen/ia64/xenbits/my01/xen-unstable.hg/xen/drivers/built_in.o
/home/yamahata/xen/ia64/xenbits/my01/xen-unstable.hg/xen/xsm/built_in.o
/home/yamahata/xen/ia64/xenbits/my01/xen-unstable.hg/xen/arch/ia64/built_in.o
\
                
/home/yamahata/xen/ia64/xenbits/my01/xen-unstable.hg/xen/common/symbols-dummy.o 
-o /home/yamahata/xen/ia64/xenbits/my01/xen-unstable.hg/xen/xen-syms
/home/yamahata/xen/ia64/xenbits/my01/xen-unstable.hg/xen/arch/ia64/built_in.o:
In function `ia64_do_tlb_purge':
/home/yamahata/xen/ia64/xenbits/my01/xen-unstable.hg/xen/arch/ia64/linux-xen/mca_asm.S:325:
undefined reference to `IA64_VCPU_VHPT_PAGE_OFFSET'
/home/yamahata/xen/ia64/xenbits/my01/xen-unstable.hg/xen/arch/ia64/linux-xen/mca_asm.S:325:
undefined reference to `IA64_VCPU_VHPT_MADDR_OFFSET'
/home/yamahata/xen/ia64/xenbits/my01/xen-unstable.hg/xen/arch/ia64/built_in.o:
In function `ia64_reload_tr':
/home/yamahata/xen/ia64/xenbits/my01/xen-unstable.hg/xen/arch/ia64/linux-xen/mca_asm.S:484:
undefined reference to `IA64_VCPU_VHPT_PAGE_OFFSET'
/home/yamahata/xen/ia64/xenbits/my01/xen-unstable.hg/xen/arch/ia64/linux-xen/mca_asm.S:484:
undefined reference to `IA64_VCPU_VHPT_MADDR_OFFSET'



On Wed, Apr 23, 2008 at 12:40:19PM +1000, Simon Horman wrote:
> arch.vhpt_page and arch.vhpt_maddr don't exist unless VHPT_ENABLED is defined.
> 
> asm-offsets.c: In function `foo':
> asm-offsets.c:257: error: structure has no member named `vhpt_page'
> asm-offsets.c:259: error: structure has no member named `vhpt_maddr'
> 
> Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
> 
> Index: xen-unstable.hg/xen/arch/ia64/asm-offsets.c
> ===================================================================
> --- xen-unstable.hg.orig/xen/arch/ia64/asm-offsets.c  2008-04-22 
> 17:32:51.000000000 +1000
> +++ xen-unstable.hg/xen/arch/ia64/asm-offsets.c       2008-04-23 
> 12:38:33.000000000 +1000
> @@ -254,10 +254,12 @@ void foo(void)
>       DEFINE(IA64_MCA_CPU_RBSTORE_OFFSET,
>              offsetof(struct ia64_mca_cpu, rbstore));
>  
> +#ifdef VHPT_ENABLED
>       DEFINE(IA64_VCPU_VHPT_PAGE_OFFSET,
>              offsetof(struct vcpu, arch.vhpt_page));
>       DEFINE(IA64_VCPU_VHPT_MADDR_OFFSET,
>              offsetof(struct vcpu, arch.vhpt_maddr));
> +#endif
>  
>       BLANK();
>       DEFINE(IA64_MCA_TLB_INFO_SIZE, sizeof(struct ia64_mca_tlb_info));
> 
> _______________________________________________
> Xen-ia64-devel mailing list
> Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-ia64-devel
> 

-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel