Re: [Xen-ia64-devel] pv_ops: imntrinsic pv_ops

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

On Mon, Apr 07, 2008 at 05:06:36PM +0800, Dong, Eddie wrote:
> It looks like you still prefer to use intermediate symbol 
> paravirt_xxxx/ia64_native_xxx to wrap ia64_xxx. In some sense, when
> I saw many similar and bulk code in the patch, I feel "dirty". I prefer
> we don't touch 
> those gcc_intrinsic.h MACROs.
> 
> If you don't like the way I wrap it, i.e. MACRO level ifdef /else.
> you may just simply provide a new head file
> for CONFIG_PARAVIRT which simply use pv_ops.name for all those same 
> MACROs.
> 
> such as in intrinsic.h:
> 
> #ifdef CONFIG_PARAVIRT_GUEST
> #include <paravirt_intrinsic.h>
> #else 
> .... gcc_intrinsic.h or intel_intrinsic.h.

Isn't renaming xxx into ia64_native_xxx (or native_xxx on x86) 
the usual way to paravirtualize/replace the function?
At least at other places, things are done so.

Do you have any reason why you don't want to touch
gcc_intrinsic.h/intel_intrinsic.h. If so, can we share that?
Anyway if your patch is better/simpler than the current code,
I'll take your patch.
(At least #undef/#define CONFIG_PARAVIRT trick is ugly.)

-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel