WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [Patch] [1/2] fix wrong emulation: move to psr

To: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] [Patch] [1/2] fix wrong emulation: move to psr
From: tgingold@xxxxxxx
Date: Wed, 19 Mar 2008 15:43:22 +0100
Cc: xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 19 Mar 2008 07:43:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <43C889C7943052takebe_akio@xxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <3FC889B6F92855takebe_akio@xxxxxxxxxxxxxx> <1205931486.47e10dded7020@xxxxxxxxxxx> <42C889C1F8AF76takebe_akio@xxxxxxxxxxxxxx> <43C889C7943052takebe_akio@xxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Internet Messaging Program (IMP) 3.2.8
Quoting Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>:

> Hi,
>
> I updated it.

Haven't you changed the behaviour of dfh:
From
-       if (newpsr.dfh) {
-               ipsr->dfh = 1;
-               PSCB(vcpu, vpsr_dfh) = 1;
-       } else {
-               ipsr->dfh = PSCB(vcpu, hpsr_dfh);
-               PSCB(vcpu, vpsr_dfh) = 0;
-       }

to

+       ipsr->dfh = newpsr.dfh;
+       PSCB(vcpu, vpsr_dfh) = newpsr.dfh;

vpsr_dfh is correct, but ipsr->dfh has changed.

Tristan.

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel