[Xen-ia64-devel] RE: simplify hw_irq.h

["Dong, Eddie" <eddie.dong@xxxxxxxxx>]

Either are fine. 

-----Original Message-----
From: Isaku Yamahata [mailto:yamahata@xxxxxxxxxxxxx] 
Sent: 2008年3月19日 10:45
To: Dong, Eddie
Cc: Alex Williamson; xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: simplify hw_irq.h

Hi Eddie.
Thank you for the patches.

ia64_vector is for iosapic redirect vector which is 8bit width, isn't it?
So just unconditionally replacing u8 with u16 seems unreasonable.
How about the following?

#ifndef CONFIG_PARAVIRT
typedef u8 ia64_vector;
#else
typedef u16 ia64_vector;
#endif


On Tue, Mar 18, 2008 at 09:30:19PM +0800, Dong, Eddie wrote:

> This one should be safe and easy to be accepted to remove
> CONFIG_XEN.
> 
> 
>     Signed-off-by: Yaozu (Eddie) Dong <eddie.dong@xxxxxxxxx>
> 
> diff --git a/include/asm-ia64/hw_irq.h b/include/asm-ia64/hw_irq.h
> index 80009cd..f670433 100644
> --- a/include/asm-ia64/hw_irq.h
> +++ b/include/asm-ia64/hw_irq.h
> @@ -15,11 +15,7 @@
>  #include <asm/ptrace.h>
>  #include <asm/smp.h>
> 
> -#ifndef CONFIG_XEN
> -typedef u8 ia64_vector;
> -#else
>  typedef u16 ia64_vector;
> -#endif
> 
>  /*
>   * 0 special



-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel