Re: [Xen-ia64-devel] pv_ops: kernel/inst_native.h

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

On Mon, Mar 17, 2008 at 11:39:45AM +0800, Dong, Eddie wrote:
> 
> Isaku/Alex:
>       There is a new file called kernel/inst_native.h to define those
> pv MACROs for native. I would suggest we do following changes:
>       1: Move it to public head files such as include/asm-ia64 at
> least since some other files will use it too.
>
>       2: Further thinking is that how we generate those dual compile
> code? If we will use symbol link, then I would suggest we put it in
> include/asm-ia64/native. Comments?

Agreed. I'm thinking similar thing.


>       3: How about this style if MACRO?
> #define MOV_FROM_CR(reg,crx) \
>         mov reg = cr.##crx
>       Using this we can reduce the patch size & avoid mistake.

It makes sense for native case. But I'm not sure how to deal with inst_xen.h.

-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel