This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-ia64-devel] [PATCH]Fix infinite loop in fault handler if debugg

To: SUZUKI Kazuhiro <kaz@xxxxxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] [PATCH]Fix infinite loop in fault handler if debugger is not connected
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Mon, 28 Jan 2008 08:35:58 -0700
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 28 Jan 2008 07:36:10 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080123.173905.61770464.kaz@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: OSLO R&D
References: <20080123.173905.61770464.kaz@xxxxxxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2008-01-23 at 17:39 +0900, SUZUKI Kazuhiro wrote:
> Hi all,
> If xen is compiled with crash_debug=y and the debugger is not
> connected, the fault handler enters infinite loop.
> The attached patch increments regs->cr_iip.

   Wouldn't it make more sense to call vcpu_increment_iip() instead of
creating a debug version that only slightly shortcuts the code?  Thanks,


Alex Williamson                             HP Open Source & Linux Org.

Xen-ia64-devel mailing list