WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-devel] [PATCH][3 of 3] GDB serial port debugging: Changes to ad

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][3 of 3] GDB serial port debugging: Changes to add SMP pausing, x86_64 register mappings for serial port GDB, and others.
From: "Dan Doucette" <doucette.daniel@xxxxxxxxx>
Date: Thu, 20 Dec 2007 12:58:54 -0800
Cc: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 20 Dec 2007 12:59:34 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; bh=0J+wdCf8wLBvSnvNqCv6hX1XPTRwdIHAJSKD1EbA/SQ=; b=C1u5yNAs/D9fCTEdsDnputWn3iYt2jrzhRweG0tWKtZfOOdD1usH3DEP9lgx1uc3RNcRwuiiXJtE5pFzbKdLexHS+gr9BKAbdjcJXOJnJznhWQzjbbuCsxFGw8QsuPuLpoaHgRXG0q60CVO2PWuSSh4Ny472dpP3cvmvQiKjcAg=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=riiK+3e0nQPIyb9Mw3EnsOxfSpz92qN20/pQqSGT8wo3Ofqietr2872gbOtx3UL+OO13ZrJX0oQjlF7rjzcES6rJ5i301HNw5GDQ7+H0EDuTlV8Lb/82Pdy+M0BR/1PfzgNGFkqoSO6URMHiaRt+jRVDyXSTMvBq/FgE/tUk8+w=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C38FE8E5.1A115%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20071220013627.GA30494%yamahata@xxxxxxxxxxxxx> <C38FE8E5.1A115%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hello,

>> Pausing/resuming cpus looks like arch generic.
>> Could you move them to the common code?
 
Yes.  Moved to common/gdbstub.c.

>> TRAP_int3 is x86 specific.
>> Please define a constant like TRAP_gdbstab in the arch header and use it.
 
The value of the vector is not used, yet.  I just removed this change from the patch.
 
>> Adding gdb_arch_write_reg() breaks other arch (IA64 and power).
>> How about adding the default definition which just returns
>> as a weak symbol?
 
>>> Just add the no-op implementation to arch/{ia64,powerpc}/gdbstub.c.
 
I added the no-op implementations to ia64 and powerpc.
 
Dan.
 
 
 
On Dec 20, 2007 1:39 AM, Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> wrote:



On 20/12/07 01:36, "Isaku Yamahata" <yamahata@xxxxxxxxxxxxx> wrote:

> Adding gdb_arch_write_reg() breaks other arch (IA64 and power).
> How about adding the default definition which just returns
> as a weak symbol?

Just add the no-op implementation to arch/{ia64,powerpc}/gdbstub.c.

 -- Keir



Attachment: gdb_patch
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>