Re: [Xen-ia64-devel] [xen-ia64][PATCH]New set OS type method

[Alex Williamson <alex.williamson@xxxxxx>]

On Wed, 2007-11-21 at 18:35 +0800, Zhang, Xing Z wrote:
> Hi Alex:
>       This patch add an OS type configure entry in script. It can replace 
> _OSI interface. 
>       User may use below format to set OS type:
> 
> In a xmexample.vti:
> # 0xB0:unknown
> # 0xB1:windows
> # 0xB2:linux
> #default is unknown
> Guest_os_type=0xB1
> 
> Comments are welcome.

Hi Wing,

   Thanks for looking into this.  Your implementation is kind of along
the lines I was thinking.  Would it make more sense to represent
Guest_os_type as a fixed length string?  There's no reason to stay with
the 0xBx specification if we're doing this through the config file (and
as a user, its unnecessarily complicated).  The down side is that it
gives the user more opportunity to make a mistake, but I think if we
give the known useful values in the example file it should be ok.  We'll
have to work with upstream on a config variable that might be
generically useful to others.

   The other question is whether we parse the string in Xen or in the
domain builder tools.  For instance, the tools might parse "Windows" and
set flags that regions 4 & 5 are identity mapped instead of just passing
that "Windows" string into Xen.  I don't know if this really adds
anything or just keeps string parsing out of Xen.

   BTW, I see your e100 driver is now in upstream.  Good work!  I'll
merge that in and try it.  Thanks again for looking at this.

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel