WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [patch 07/16] Kexec: Call xen_machine_kexec_registe

To: Alex Williamson <alex.williamson@xxxxxx>
Subject: Re: [Xen-ia64-devel] [patch 07/16] Kexec: Call xen_machine_kexec_register_resources
From: Horms <horms@xxxxxxxxxxxx>
Date: Tue, 25 Sep 2007 11:40:08 +0900
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 24 Sep 2007 20:00:04 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1189633139.6287.32.camel@lappy>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070912082834.175658477@xxxxxxxxxxxx> <20070912083045.075887721@xxxxxxxxxxxx> <1189633139.6287.32.camel@lappy>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: mutt-ng/devel-r804 (Debian)
On Wed, Sep 12, 2007 at 03:38:59PM -0600, Alex Williamson wrote:
> On Wed, 2007-09-12 at 17:28 +0900, Simon Horman wrote:
> > plain text document attachment
> > (ia64-kexec-efi_initialize_iomem_resources.patch)
> > For kexec on xen xen_machine_kexec_register_resources() needs
> > to be called at boot time.
> 
> > Index: linux-2.6.18-xen.hg/arch/ia64/kernel/efi.c
> > ===================================================================
> > --- linux-2.6.18-xen.hg.orig/arch/ia64/kernel/efi.c 2007-07-10 
> > 10:57:17.000000000 +0900
> > +++ linux-2.6.18-xen.hg/arch/ia64/kernel/efi.c      2007-07-10 
> > 11:11:09.000000000 +0900
> > @@ -1128,6 +1128,9 @@ efi_initialize_iomem_resources(struct re
> >                          insert_resource(res, &boot_param_res);
> >                     if (crashk_res.end > crashk_res.start)
> >                             insert_resource(res, &crashk_res);
> > +#ifdef CONFIG_XEN
> > +                   xen_machine_kexec_register_resources(res);
> > +#endif
> >  #endif
> 
>   Won't this break transparent paravirt?  Might need a CONFIG_KEXEC too.
> Is kexec supposed to do anything on non-dom0 domains?  If not, wrap it
> in an 'if (is_initial_xendomain())', otherwise use is_running_on_xen().
> Thanks,

Hi Alex,

Although it isn't clear from the patch, the code is gaurded by CONFIG_KEXEC.

As you suggest, xen_machine_kexec_register_resources() needed to
be protected, I have used is_initial_xendomain() as this port
of kexec isn't supposed to do anything on non-privelaged domains (yet).

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel