WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

[Xen-ia64-devel] [PATCH] Remove unused var opt_xenheap_megabytes

To: Alex Williamson <alex.williamson@xxxxxx>
Subject: [Xen-ia64-devel] [PATCH] Remove unused var opt_xenheap_megabytes
From: Aron Griffis <aron@xxxxxx>
Date: Mon, 27 Aug 2007 13:28:07 -0400
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 27 Aug 2007 10:29:06 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Aron Griffis <aron@xxxxxx>
# Date 1188235669 14400
# Node ID 541f589d09feb4b99a93b45134a245cae60b24de
# Parent  c221bb40b5fdac267463fd69f3521b497948737f
Remove unused var opt_xenheap_megabytes

x86 and ppc use opt_xenheap_megabytes; ia64 doesn't so remove it.  Also clean up
some comments; add some __init and __initdata where appropriate

Tested booting dom0 on rx1620

Signed-off-by: Aron Griffis <aron@xxxxxx>

diff -r c221bb40b5fd -r 541f589d09fe xen/arch/ia64/xen/xensetup.c
--- a/xen/arch/ia64/xen/xensetup.c      Mon Aug 27 11:55:28 2007 -0400
+++ b/xen/arch/ia64/xen/xensetup.c      Mon Aug 27 13:27:49 2007 -0400
@@ -52,35 +52,24 @@ extern void trap_init(void);
 extern void trap_init(void);
 extern void xen_patch_kernel(void);
 
-/* opt_nosmp: If true, secondary processors are ignored. */
-static int opt_nosmp;
+/* nosmp: ignore secondary processors */
+static int __initdata opt_nosmp;
 boolean_param("nosmp", opt_nosmp);
 
-/* maxcpus: maximum number of CPUs to activate. */
+/* maxcpus: maximum number of CPUs to activate */
 static unsigned int __initdata max_cpus = NR_CPUS;
 integer_param("maxcpus", max_cpus); 
 
-/* xencons: if true enable xenconsole input (and irq).
+/* xencons: toggle xenconsole input (and irq).
    Note: you have to disable 8250 serials in domains (to avoid use of the
    same resource).  */
 static int __initdata opt_xencons = 1;
 integer_param("xencons", opt_xencons);
 
-/* Toggle to allow non-legacy xencons UARTs to run in polling mode */
+/* xencons_poll: toggle non-legacy xencons UARTs to run in polling mode */
 static int __initdata opt_xencons_poll;
 boolean_param("xencons_poll", opt_xencons_poll);
 
-/*
- * opt_xenheap_megabytes: Size of Xen heap in megabytes, including:
- *     xen image
- *     bootmap bits
- *     xen heap
- * Note: To allow xenheap size configurable, the prerequisite is
- * to configure elilo allowing relocation defaultly. Then since
- * elilo chooses 256M as alignment when relocating, alignment issue
- * on IPF can be addressed.
- */
-unsigned int opt_xenheap_megabytes = XENHEAP_DEFAULT_MB;
 unsigned long xenheap_size = XENHEAP_DEFAULT_SIZE;
 unsigned long xen_pstart;
 void *xen_pickle_offset __read_mostly;
@@ -105,7 +94,7 @@ static void __init do_initcalls(void)
 }
 
 /*
- * IPF loader only supports one commaind line currently, for
+ * IPF loader only supports one command line currently, for
  * both xen and guest kernel. This function provides pre-parse
  * to mixed command line, to split it into two parts.
  *
@@ -196,7 +185,7 @@ efi_print(void)
  * These functions are utility functions for getting and
  * testing memory descriptors for allocating the xenheap area.
  */
-static efi_memory_desc_t *
+static efi_memory_desc_t * __init
 efi_get_md (unsigned long phys_addr)
 {
     void *efi_map_start, *efi_map_end, *p;
@@ -215,7 +204,7 @@ efi_get_md (unsigned long phys_addr)
     return 0;
 }
 
-static int
+static int __init
 is_xenheap_usable_memory(efi_memory_desc_t *md)
 {
     if (!(md->attribute & EFI_MEMORY_WB))
@@ -232,7 +221,7 @@ is_xenheap_usable_memory(efi_memory_desc
     return 0;
 }
 
-static inline int
+static inline int __init
 md_overlaps(efi_memory_desc_t *md, unsigned long phys_addr)
 {
     return (phys_addr - md->phys_addr < (md->num_pages << EFI_PAGE_SHIFT));

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-ia64-devel] [PATCH] Remove unused var opt_xenheap_megabytes, Aron Griffis <=