[Xen-devel] RE: [Xen-ia64-devel] [PATCH][RFC] Fix error message for xm createcommand

["Zhang, Xing Z" <xing.z.zhang@xxxxxxxxx>]

Hi Kanno:
        I did a quick investigation and found some codes perform strange.
        As I know, XEND do below flow to create a domain:
        XendDomain(single one)  ---------> XendDomainInfo(represent a domain) 
-------->Image(a set of handle)

        When XendDomainInfo init, it executes below codes:

        ( __init__ function)
           self.info = info 
        if domid == None:
            self.domid =  self.info.get('domid')
        else:
        self.domid = domid

        I originally thought these codes could guarantee domid is not none. But 
seems it's un-use when a error raise. The domid in info is still none! 
        I am also not familiar with details of Xend. Anyway, I think you patch 
makes the code strong. 

>-----Original Message-----
>From: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
>[mailto:xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Masaki Kanno
>Sent: 2007年8月27日 15:22
>To: xen-devel@xxxxxxxxxxxxxxxxxxx; xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
>Subject: [Xen-ia64-devel] [PATCH][RFC] Fix error message for xm createcommand
>
>Hi,
>
>When I tested xm create command, I saw the following error message.
>I expected an error message "Error: (12, 'Cannot allocate memory')"
>because I intentionally caused a memory shortage on the test.
>But the error message was different from my expectation.
>
># xm create /xen/HVMdomain.1
>Using config file "/xen/HVMdomain.1".
>Error: an integer is required
>
>I looked at xend.log to examine the cause why the error message was
>shown.  (Could you see the attached xend.log?)
>xend had the error message "Error: (12, 'Cannot allocate memory')"
>first.  But xend changed the error message to "Error: an integer is
>required" halfway.
>I'm not sure about the cause why an exception occurred in logging
>processing.  But when I applied an attached patch, I confirmed that
>the error message that I expected was shown.  The patch does not
>call xc.domain_destroy_hook() if self.domid is None.
>
>Could you comment on the patch?  I'd like to solve the problem
>because I think that users want correct error message.
>
>
>Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
>
>Best regards,
> Kan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel