WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

[Xen-ia64-devel] Re: [Xen-devel] [Patch] ARCH_HAS_DEV_MEM patch for Xwin

To: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Subject: [Xen-ia64-devel] Re: [Xen-devel] [Patch] ARCH_HAS_DEV_MEM patch for Xwindow on IA64machine
From: Jun Kamada <kama@xxxxxxxxxxxxxx>
Date: Fri, 06 Jul 2007 18:46:56 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 06 Jul 2007 02:45:21 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <468BA902.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070704203821.B340.KAMA@xxxxxxxxxxxxxx> <468BA902.76E4.0078.0@xxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi, Jan-san,

On Wed, 04 Jul 2007 13:04:50 +0100
"Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
> >--- a/drivers/xen/Makefile   Thu Jun 21 15:12:20 2007 +0900
> >+++ b/drivers/xen/Makefile   Thu Jun 21 15:13:21 2007 +0900
> >@@ -5,9 +5,9 @@ obj-y        += xenbus/
> > obj-y       += xenbus/
> > obj-y       += gntdev/
> > obj-y       += balloon/
> >-obj-y       += char/
> > 
> > obj-y       += util.o
> >+obj-$(CONFIG_XEN_DEVMEM)            += char/
> > obj-$(CONFIG_XEN_BLKDEV_BACKEND)    += blkback/
> > obj-$(CONFIG_XEN_BLKDEV_TAP)                += blktap/
> > obj-$(CONFIG_XEN_NETDEV_BACKEND)    += netback/
> 
> This is certainly wrong. Even if driver/xen/char/ currently only has a
> single file, you should descend into that directory. The conditional
> (if needed at all) should then be in driver/xen/char/Makefile.

I modified the patch acording to your comment.

Thanks,

-----
Jun Kamada
Linux Technology Development Div.
Server Systems Unit
Fujitsu Ltd.
kama@xxxxxxxxxxxxxx

Attachment: ifdef_arch_has_dev_mem.patch
Description: Binary data

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel
<Prev in Thread] Current Thread [Next in Thread>