RE: [Xen-ia64-devel] [Xen-ia64][PATCH] Fix NVRAM data can not be

On Wed, 2007-06-27 at 10:37 +0800, Zhang, Xing Z wrote:
> >> Alex, If you agree with this patch, could you check in it ASAP and
> >> push it into Xen-unstable tree? So that RH can pick this patch for
> >> RHEL5.1.
> >>
> >> Any comment is welcome. Thx.
> >
> >   Isn't this rather asymmetrical with our domain destroy hook?  Why
> >can't we do something similar here?  Overloading the function with a
> >#def is pretty ugly.  Thanks,
> [Zhang, Xing Z] 
> Thanks your comments. But seems xc_domain.c belongs to libxenctrl.so
> while xc_ia64_hvm_build.c belongs to libxenguest.so. Can the function in
> libxenctrl.so call a function which in libxenguest.so? I add a hook in
> xc_domain.c but compiler complaining at link time.

   Why must the hook be implemented in xc_ia64_hvm_build.c?  It's
definitely the obvious candidate, but we could also make it an
architecture dependent static inline in something like vl.h, where the
overloading occurs now.  The overloading is a nice trick, but a context
dependent function like that seems prone to errors to me.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

Re: [Xen-ia64-devel] GET_THIS_PADDR appears to be broken, Tristan Gingold

Next by Date:

Re: [Xen-ia64-devel] GET_THIS_PADDR appears to be broken, Horms

Previous by Thread:

RE: [Xen-ia64-devel] [Xen-ia64][PATCH] Fix NVRAM data can not besaved when guest execute "reboot" instruction, Zhang, Xing Z

Next by Thread:

RE: [Xen-ia64-devel] [Xen-ia64][PATCH] Fix NVRAM data can notbesaved when guest execute "reboot" instruction, Zhang, Xing Z

Indexes:

[Date] [Thread] [Top] [All Lists]