WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] PATCH: rbs in vcpu_guest_context_regs

To: tgingold@xxxxxxx
Subject: Re: [Xen-ia64-devel] PATCH: rbs in vcpu_guest_context_regs
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Fri, 22 Jun 2007 19:09:13 +0900
Cc: Alex Williamson <alex.williamson@xxxxxx>, Xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 22 Jun 2007 03:07:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070615044759.GA2241@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070615044759.GA2241@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Fri, Jun 15, 2007 at 06:47:59AM +0200, tgingold@xxxxxxx wrote:

> +#if (IA64_RBS_OFFSET % 512) != IA64_GUEST_CONTEXT_RBS_OFFSET
> +# error "arch-ia64.h: IA64_GUEST_CONTEXT_RBS_OFFSET must be adjusted."
> +#endif
> +
...
> +#define IA64_GUEST_CONTEXT_RBS_OFFSET 448
>          unsigned long rbs[2048];
> -#endif
> +        unsigned long rbs_nat;
>  };


IA64_RBS_OFFSET is defined based on sizeof(struct vcpu),
so is IA64_GUEST_CONTEXT_RBS_OFFSET.
It means that IA64_GUEST_CONTEXT_RBS_OFFSET must be updated
every time struct vcpu/arch_vcpu are changed.
Although Xen/IA64 developper haven't taken care of ABI stability
so much, this case is too unstable.

Can we remove the constant and add another interface to get the value
dynamically?
-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>