Re: [Xen-ia64-devel] [patch] increase xen-heap-size based on nodes-shift

[Jes Sorensen <jes@xxxxxxx>]

Isaku Yamahata wrote:
> On Wed, Jun 13, 2007 at 05:12:47PM +0200, Jes Sorensen wrote:
>> We could do that, but I think we should do it on top of my patch. Ie.
>> I think it's better to have a too large heap per default and then let
>> the users reduce it rather than the other way round. What do you think?
> 
> The default value won't matter so much as long as xenheap_megabytes option
> is introduced, I think.

I disagree, I think it's very important that the default value is safe,
so users don't end up with strange error messages that they do not
understand.

>> +#define XENHEAP_DEFAULT_MB     XENHEAP_DEFAULT_SIZE >> 20
> 
> It would be better to use parens.

I'm not really biased, both work for me :-)

Regards,
Jes

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel