WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [PATCH] add paddr_t definition to compile gnttab.c (was Re: [Xen-ia6

To: Alex Williamson <alex.williamson@xxxxxx>
Subject: Re: [PATCH] add paddr_t definition to compile gnttab.c (was Re: [Xen-ia64-devel] [RFC] gnttab unmap_and_replace)
From: Jes Sorensen <jes@xxxxxxx>
Date: 13 Jun 2007 07:19:01 -0400
Cc: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 13 Jun 2007 04:16:48 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1181595113.6221.502.camel@bling>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070605142710.GB25309%yamahata@xxxxxxxxxxxxx> <1181064917.6221.224.camel@bling> <20070608105418.GH29054%yamahata@xxxxxxxxxxxxx> <1181595113.6221.502.camel@bling>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.4
>>>>> "Alex" == Alex Williamson <alex.williamson@xxxxxx> writes:

Alex> On Fri, 2007-06-08 at 19:54 +0900, Isaku Yamahata wrote:
>> add paddr_t definition to compile gnttab.c
>> 
>> On Tue, Jun 05, 2007 at 11:35:17AM -0600, Alex Williamson wrote:
>> > 
>> > We could typedef paddr_t as we've done for maddr_t.  We may
>> continue > to get broken by such changes in the future otherwise.
>> The pfn_valid() > change doesn't seem like it should be
>> controversial.  Thanks,

Alex>    Hmm, sn already typedefs paddr_t causing a conflict.  Did
Alex> this patch build for you?  Thanks,

Ewww, I've been trying to get rid of those silly typedefs for years :-(
Guess some of them are still in an old patch queue somewhere.

Adding a paddr_t to Xen is really the wrong thing to do IMHO.
Remember: typedef's considered harmful!

Cheers,
Jes

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel