WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] regarding dom_fw_setup

To: jeet <jeet_sat12@xxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] regarding dom_fw_setup
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Mon, 4 Jun 2007 12:17:09 +0900
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sun, 03 Jun 2007 20:15:20 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <913636.20192.qm@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <913636.20192.qm@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
Good catch.
It's fixed in the tip of xen-ia64-devel.hg. (15154:b46c2ff6dfb0)
Is there any other suspicious code?

On Sun, Jun 03, 2007 at 05:02:51PM +0530, jeet wrote:
> Hi All
> 
> I am looking into code of construct_dom0()
> 
> which call dom_fw_setup() to setup the firmware related mapping in 
> domain identity mapped virtual address space
> 
> But in dom_fw_setup() it there is a code as below
> 
> <snippet start>
>   /* Create page for acpi tables.  */
>        if (d != dom0) {
>             void *imva;
>  
>              assign_new_domain_page_if_dom0(d, FW_ACPI_BASE_PADDR);
>                  imva = doamin_mps_to_imva (d, FW_ACPI_BASE_PADDR);
>                 dom_fw_fake_acpi(d, (struct fake_acpi_tables *)imva);
>         }
> <snippet end>
> 
> here if it is not dom0 then it call 
> assign_new_domain_page_if_dom0
> 
> but inside this it checking if dom=dom0 then it assign page otherwise return
> So what is purpose of this code here?
> 
> or the check should be if (d == dom0) ?
> 
> jeet
> 
> 
> 
> 
>       Looking for people who are YOUR TYPE? Find them at in.groups.yahoo.com
> 
> _______________________________________________
> Xen-ia64-devel mailing list
> Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-ia64-devel
> 

-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>