WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

[Xen-ia64-devel] Re: PATCH: all registers in vcpu_guest_context

To: Alex Williamson <alex.williamson@xxxxxx>
Subject: [Xen-ia64-devel] Re: PATCH: all registers in vcpu_guest_context
From: Tristan Gingold <tgingold@xxxxxxx>
Date: Wed, 30 May 2007 01:40:47 +0200
Cc: Xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 29 May 2007 16:33:52 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1180475672.6756.41.camel@lappy>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070506044328.GA2928@saphi> <1180475672.6756.41.camel@lappy>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Tue, May 29, 2007 at 03:54:32PM -0600, Alex Williamson wrote:
> Hi Tristan,
> 
>    Looks like this patch is causing some problems:
> 
> http://xenbits.xensource.com/ext/xen-ia64-unstable.hg?rev/7c176473786b
> 
> Most of my machines work with it, but one fails to boot dom0.  That box
> gets a NaT consumption fault with an IIP well above xen text space.  If
> I chop the rbs array off the end of the vcpu_guest_context_regs it boots
> fine.  This gets the structure down to a little over 5k.  I see several
> places where this structure is allocated on the stack.  Are we blowing
> up the stack with a 21k+ structure?  Suggestions for a fix?  Thanks,
This seems to be a good reason.
As a work-around, you may #if 0 the rbs array because it is not yet used.

After a look the structure is allocated on the stack at two places: when a
vcpu is started (PV and VTi).  Do you confirm ?
Because this is not performance critical, we can xmalloc it in these cases.

Tristan.

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel