WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [PATCH 14/14] memmap: allow huge size efi memory ma

To: Alex Williamson <alex.williamson@xxxxxx>
Subject: Re: [Xen-ia64-devel] [PATCH 14/14] memmap: allow huge size efi memory map of real machine
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Fri, 25 May 2007 18:57:22 +0900
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 25 May 2007 02:55:25 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070523121444.GC4949%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070517104357.GA14091%yamahata@xxxxxxxxxxxxx> <1179883948.6134.182.camel@bling> <20070523121444.GC4949%yamahata@xxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
Hi Alex.

I attached the updated one.
I tested it on tiger4 whose efi memory map is replaced with
superdome's efi memory map. I created the EFI memory map
according to the one which is reported at
http://bugzilla.xensource.com/bugzilla/attachment.cgi?id=540&action=view
It successfully created efi memory map for dom0 and
passed the control to dom0.

I also tested the patch with debug=y. In that case, xen xmalloc
allocator does rough memory corruption check. It didn't report
memory corruption.
If you still see problems, can you send the memory map of the machine?

P.S.
I produced the patch against xen-ia64-unstable.hg so that
its format is xen style.
If Linux style is desirable, I will recreated after you commit
the reformatting patch.

On Wed, May 23, 2007 at 09:14:44PM +0900, Isaku Yamahata wrote:
> On Tue, May 22, 2007 at 07:32:28PM -0600, Alex Williamson wrote:
> 
> > Even with that fix, my system hangs at the xfree(fw_tables) call near
> > the end of this chunk.  If I skip that xfree(), we hang at the next call
> > to xfree.  Looks like we corrupted memory somewhere, but I haven't found
> > it yet.
> 
> Thanks for debugging and sorry for those bugs.
> Although I reviewed the patch, I've not found memory corruption yet.
> I attached my current clean up patch for those who want to debug it.
> 
> 
> > In this case NUM_MEM_DESCS should be very small since it's only adding
> > the descriptors we add for xen and the rest is dynamically sized based
> > on the number of entries in the MDT provided by firmware.  Thanks,
> 
> I'll postpone reducing NUM_MEM_DESCS until memory corruption fix.
> 
> -- 
> yamahata


> _______________________________________________
> Xen-ia64-devel mailing list
> Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-ia64-devel

-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel