xen-ia64-devel

[Top] [All Lists]

Re: [Xen-ia64-devel] [Patch] Remove panic_domain()

from [Alex Williamson]

[Permanent Link][Original]

To:	Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
Subject:	Re: [Xen-ia64-devel] [Patch] Remove panic_domain()
From:	Alex Williamson <alex.williamson@xxxxxx>
Date:	Mon, 26 Mar 2007 09:36:03 -0600
Cc:	xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Mon, 26 Mar 2007 08:34:51 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<E8C76D10984B89takebe_akio@xxxxxxxxxxxxxx>
List-help:	<mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id:	Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post:	<mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Organization:	HP OSLO R&D
References:	<E8C76D10984B89takebe_akio@xxxxxxxxxxxxxx>
Sender:	xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx

On Fri, 2007-03-23 at 15:00 +0900, Akio Takebe wrote:
> Hi,
> 
> I found the bug of panic_domain().
> When we compile xen with crash_debug=y, debugger_trap_immediate() and 
> debugger_trap_fatal() is not nop.
> So if xen call panic_domain() to crash guest,
> xen call debugger routine, then hangup system.
> 
> domain_crash_synchronous() has __FILE__, __LINE__ macros.
> So I remove panic_domain() and replace it with printk() and
> domain_crash_synchronous() as x86 do.

   Wouldn't it work just as well to convert panic_domain() to a macro
and remove the debugger_trap_immediate() and debugger_trap_fatal()
calls?  The abstraction of panic_domain() is easier to use than
requiring someone to call all the relevant functions manually.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-ia64-devel] [Patch] Remove panic_domain(), Akio Takebe Re: [Xen-ia64-devel] [Patch] Remove panic_domain(), Alex Williamson <= Re: [Xen-ia64-devel] [Patch] Remove panic_domain(), Akio Takebe Re: [Xen-ia64-devel] [Patch] Remove panic_domain(), Akio Takebe Re: [Xen-ia64-devel] [Patch] Remove panic_domain(), Alex Williamson

Previous by Date:	Re: [Xen-ia64-devel] Re: [PATCH] fix the ia64 p2m semantic, Doi . Tsunehisa
Next by Date:	Re: [Xen-ia64-devel] Re: [PATCH] fix the ia64 p2m semantic, Alex Williamson
Previous by Thread:	[Xen-ia64-devel] [Patch] Remove panic_domain(), Akio Takebe
Next by Thread:	Re: [Xen-ia64-devel] [Patch] Remove panic_domain(), Akio Takebe
Indexes:	[Date] [Thread] [Top] [All Lists]