WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

RE: [Xen-ia64-devel] [PATCH] bug fix new_tlbflush_clock_period()

To: "Isaku Yamahata" <yamahata@xxxxxxxxxxxxx>
Subject: RE: [Xen-ia64-devel] [PATCH] bug fix new_tlbflush_clock_period()
From: "Xu, Anthony" <anthony.xu@xxxxxxxxx>
Date: Mon, 5 Feb 2007 13:11:38 +0800
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sun, 04 Feb 2007 21:10:57 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070205045918.GF10566%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdI4nxtIDRuSQLxS6G4y004I1vZCgAAN5Kg
Thread-topic: [Xen-ia64-devel] [PATCH] bug fix new_tlbflush_clock_period()
Isaku Yamahata write on 2007年2月5日 12:59:
> On Mon, Feb 05, 2007 at 11:47:28AM +0800, Xu, Anthony wrote:
>> Isaku Yamahata write on 2007年2月5日 11:43:
>>> On Mon, Feb 05, 2007 at 11:34:59AM +0800, Xu, Anthony wrote:
>>>> Before calling local_vhpt_flush,
>>>> We need to make sure it is not VTI-domain and it is not per-VCPU
>>>> VHPT,
>>> 
>>> local_vhpt_flush() always flushes vhpt associated to pcpu. not vcpu.
>> 
>> If HAS_PERVCPU_VHPT(current->domain) is true, or VMX_DOMAIN
>> (current) is true. 
>> 
>> Vhpt_paddr may be 0,
>> So It erases 64KB memory content that starts from machine address 0.
> 
> vhpt_init() initializes vhpt_paddr at xen boot time.

Yes, there is no correctness issue.
But it is a waste of time to call local_vhpt_flsh if it is unnecessary.

And if CONFIG_XEN_IA64_PERVCPU_VHPT is defined,
Vhpt_init should not allocate per-pcpu vhpt, it is a waste of memory.


- Anthony

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel