This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Clean up and fix errors in strncpy -> strlcpy co

To: Christoph Egger <Christoph.Egger@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Clean up and fix errors in strncpy -> strlcpy conversion
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 30 Jan 2007 15:46:47 +0000
Cc: Aron Griffis <aron@xxxxxx>, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 30 Jan 2007 07:46:35 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200701301626.38799.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdEhdlHGDZjLLB5Eduv7gANk04WTA==
Thread-topic: [Xen-devel] [PATCH] Clean up and fix errors in strncpy -> strlcpy conversion
User-agent: Microsoft-Entourage/

On 30/1/07 3:26 pm, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

>> You're confusing the cleanups with the bugfixes.  Any use of
>> safe_strcpy() in my patch was just cleanup.
>> The bugfixes are on the signature fields (the first change quoted
>> above), which I changed to use memcpy since strlcpy adds an unwanted
>> NUL.
> Aron: If the above patch is still correct (against CS 13703), please resend it
> for Keir to apply.

The original patch still applies cleanly to xen-unstable so I'll apply it
without a resend.

 -- Keir

Xen-devel mailing list