WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

[Xen-ia64-devel] [PATCH] NEW_TLBFLUSH_CLOCK_PERIOD_SOFTIRQ is not regist

To: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-ia64-devel] [PATCH] NEW_TLBFLUSH_CLOCK_PERIOD_SOFTIRQ is not registered.
From: Kouya SHIMURA <kouya@xxxxxxxxxxxxxx>
Date: Fri, 26 Jan 2007 20:05:52 +0900
Delivery-date: Fri, 26 Jan 2007 03:06:12 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi

NEW_TLBFLUSH_CLOCK_PERIOD_SOFTIRQ is used but not registered.
I've never experienced but system will panic in the very long run. 
I wonder why Isaku missed it.

Thanks,
Kouya

Signed-off-by: Kouya Shimura <kouya@xxxxxxxxxxxxxx>

diff -r b4df7de0cbf7 xen/arch/ia64/xen/xensetup.c
--- a/xen/arch/ia64/xen/xensetup.c      Wed Jan 24 12:28:05 2007 -0700
+++ b/xen/arch/ia64/xen/xensetup.c      Fri Jan 26 18:57:54 2007 +0900
@@ -26,6 +26,7 @@
 #include <asm/vmx.h>
 #include <linux/efi.h>
 #include <asm/iosapic.h>
+#include <xen/softirq.h>
 
 unsigned long xenheap_phys_end, total_pages;
 
@@ -436,6 +437,10 @@ void start_kernel(void)
     init_xen_time(); /* initialise the time */
     timer_init();
 
+#ifdef CONFIG_XEN_IA64_TLBFLUSH_CLOCK
+    open_softirq(NEW_TLBFLUSH_CLOCK_PERIOD_SOFTIRQ, new_tlbflush_clock_period);
+#endif
+
 #ifdef CONFIG_SMP
     if ( opt_nosmp )
     {
diff -r b4df7de0cbf7 xen/include/asm-ia64/flushtlb.h
--- a/xen/include/asm-ia64/flushtlb.h   Wed Jan 24 12:28:05 2007 -0700
+++ b/xen/include/asm-ia64/flushtlb.h   Fri Jan 26 18:57:54 2007 +0900
@@ -32,6 +32,7 @@ extern volatile u32 tlbflush_clock;
 #define tlbflush_current_time() tlbflush_clock
 
 u32 tlbflush_clock_inc_and_return(void);
+void new_tlbflush_clock_period(void);
 
 static inline void
 tlbflush_update_time(volatile u32* time, u32 timestamp)
_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel