This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH][RFC] correction trouble of short message in UDP

To: Keir Fraser <keir@xxxxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][RFC] correction trouble of short message in UDP
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Thu, 25 Jan 2007 14:06:18 +0000
Cc: t.horikoshi@xxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 25 Jan 2007 06:08:00 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C1DE6927.8345%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdAiZD0z3KIeax8EduKvwAX8io7RQAAGqxN
Thread-topic: [Xen-devel] [PATCH][RFC] correction trouble of short message in UDP
User-agent: Microsoft-Entourage/
On 25/1/07 14:03, "Keir Fraser" <keir@xxxxxxxxxxxxx> wrote:

>> How about making the total number of grant table entries equal the
>> number of TX slots? That way we won't have to check anything at all.
>> It also doesn't make sense to have more TX slots than grant table entries.
> Yes, this is a good idea!
> So we should replace current netfront_tx_slot_available implementation with:
>  (tx->req_prod_pvt - tx->rsp_cons) < (TX_MAX_TARGET - MAX_SKB_FRAGS - 2)
> ??

Sorry, what I'm suggesting actually isn't the same as your proposal. :-)

I think mine would work though, and 256 grants should be plenty as a

 -- Keir

Xen-devel mailing list