RE: [Xen-ia64-devel] [PATCH] Fix freeing of privregs structure fordomVTi

[Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>]

Hi Anthiny,

>Masaki Kanno write on 2007年1月11日 16:24:
>> Hi,
>
>Hi Kanno,
>
>Good catch!
>
>I have below comment.
>
>The root cause is,  vhpt and privregs for xeno are allocated at hypercall
>XEN-DOMCTL_max_vcpus, at that time d->arch.is_vti is not set yet.
>When d->arch.is_vti is set, vhpt and privregs allocated for xeno are 
>released, 
>and vhpt and privregs for VTI are allocated at this time.
>
>This logic is a little bit ugly.

I also think so.

>Can we postpone vhpt and privregs allocation until d->arch.is_vti is set?

I'll try it. Could you wait a few days?

Best regards,
 Kan

>One place is at xen/arch/ia64/xen/arch_set_info_guest,
>
>If(d->arch.is_vti)
>       vmx_final_setup_guest(v);
>Else{ 
>/*TODO  We can move vhpt and privregs logic for xeno here. */
>
>}
>
>What's your opinioin?
>
>Thanks,
>Anthony
>
>> 
>> When I repeated creation and destruction of domVTi, I found a bug.
>> It is memory leak of privregs structure.
>> This patch fixes the bug.
>> 
>> Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
>> 
>> Best regards,
>>  Kan


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel