This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-ia64-devel] Small bug in handling of domU's itc ops

To: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] Small bug in handling of domU's itc ops
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Fri, 15 Dec 2006 08:54:31 -0700
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 15 Dec 2006 07:54:22 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200612151355.59424.dietmar.hahn@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: OSLO R&D
References: <200612151355.59424.dietmar.hahn@xxxxxxxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2006-12-15 at 13:55 +0100, Dietmar Hahn wrote:
> diff -r 2fc3392d0889 -r a9ea368e59a5 xen/arch/ia64/xen/vcpu.c
> --- a/xen/arch/ia64/xen/vcpu.c        Thu Dec 14 09:56:41 2006 -0700
> +++ b/xen/arch/ia64/xen/vcpu.c        Fri Dec 15 13:35:36 2006 +0100
> @@ -2162,6 +2162,7 @@ vcpu_itc_no_srlz(VCPU * vcpu, u64 IorD, 
>       BUG_ON(logps > PAGE_SHIFT);
>       vcpu_tlb_track_insert_or_dirty(vcpu, vaddr, entry);
>       psr = ia64_clear_ic();
> +     pte &= ~((0x3UL<<50) | 0x1<<1); // Mask out the reserved bits.
>       ia64_itc(IorD, vaddr, pte, ps); // FIXME: look for bigger mappings
>       ia64_set_psr(psr);
>       // ia64_srlz_i(); // no srls req'd, will rfi later

Hi Dietmar,

   This looks ok, but I would prefer to have a macros of the reserved
bitmask in a header somewhere.  Thanks,


Alex Williamson                             HP Open Source & Linux Org.

Xen-ia64-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>