WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [PATCH] change XEN_DOMCTL_getmemlist returns gmfn i

To: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-ia64-devel] [PATCH] change XEN_DOMCTL_getmemlist returns gmfn instead of mfn
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Fri, 8 Dec 2006 11:33:03 +0900
Delivery-date: Thu, 07 Dec 2006 18:32:55 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061208022441.GB9099%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20061208022441.GB9099%yamahata@xxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
Sorry. I sent out the wrong old patch.
I Attached the corrected one.

On Fri, Dec 08, 2006 at 11:24:41AM +0900, Isaku Yamahata wrote:
> change XEN_DOMCTL_getmemlist returns gmfn instead of mfn for foreign domain
> page mapping.
> 
> This patch tries to get 'xm dump-core' work on ia64 again.
> With this patch, 'xm dump-core' results in creating core-dump file
> as before with a slight format changes.
> (machine address array -> pseudo physicall address array)
> However xm dump-core has been broken on ia64 since 
> XEN_DOMCTL_getmemlist/ia64 is differenct from x86's.
> This patch does NOT fix it.
> 
> The following quick hack might fix it, but I think that 
> the right fix is to join the discussion which begins with
> http://lists.xensource.com/archives/html/xen-devel/2006-11/msg01226.html
> and probably to re-implement xc_core.c without xc_get_pfn_list() which is
> deprecated.
> 
> diff -r 471c8119946f -r a128ef2b56cf tools/libxc/xc_core.c
> --- a/tools/libxc/xc_core.c     Mon Oct 16 16:16:07 2006 +0900
> +++ b/tools/libxc/xc_core.c     Tue Nov 21 14:58:34 2006 +0900
> @@ -60,7 +60,11 @@ xc_domain_dumpcore_via_callback(int xc_h
>          if ( xc_vcpu_getcontext(xc_handle, domid, i, &ctxt[nr_vcpus]) == 0)
>              nr_vcpus++;
>  
> +#ifndef __ia64__
>      nr_pages = info.nr_pages;
> +#else
> +    nr_pages = info.max_memkb >> (PAGE_SHIFT - 10);
> +#endif
>  
>      header.xch_magic = info.hvm ? XC_CORE_MAGIC_HVM : XC_CORE_MAGIC;
>      header.xch_nr_vcpus = nr_vcpus;
> 
> -- 
> yamahata

> # HG changeset patch
> # User yamahata@xxxxxxxxxxxxx
> # Date 1165481074 -32400
> # Node ID ba353f0b2f52bd230e85d849d6967b25490b4bc6
> # Parent  0ee772ac96c5737ef3c220615c028aebe5a55601
> change XEN_DOMCTL_getmemlist returns gmfn instead of mfn for foreign domain
> page mapping.
> PATCHNAME: xen_domctl_getmemlist_gmfn
> 
> Signed-off-by: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
> 
> diff -r 0ee772ac96c5 -r ba353f0b2f52 xen/arch/ia64/xen/dom0_ops.c
> --- a/xen/arch/ia64/xen/dom0_ops.c    Thu Dec 07 17:25:03 2006 +0900
> +++ b/xen/arch/ia64/xen/dom0_ops.c    Thu Dec 07 17:44:34 2006 +0900
> @@ -55,7 +55,7 @@ long arch_do_domctl(xen_domctl_t *op, XE
>              pte = (pte_t *)lookup_noalloc_domain_pte(d,
>                                                 (start_page + i) << 
> PAGE_SHIFT);
>              if (pte && pte_present(*pte))
> -                mfn = pte_pfn(*pte);
> +                mfn = i;
>              else
>                  mfn = INVALID_MFN;
>  

> _______________________________________________
> Xen-ia64-devel mailing list
> Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-ia64-devel

-- 
yamahata

Attachment: 12803_ba353f0b2f52_xen_domctl_getmemlist_gmfn.patch
Description: Text document

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel
<Prev in Thread] Current Thread [Next in Thread>