Hi Yamahata:
Thanks for your mention.
With your patch, seems we can pass pfn to xc_map_foreign_range(). As
you said, change in populate_physmap() seems unnecessary. But I noticed IA32
still have this logic. So I think xc_domain_memory_populate_physmap() also need
auto-translate mechanism. we should pass pfn to xc_map_foreign_range() solely
but not use gpfn array which pass to xc_domain_memory_populate_physmap(). IA32
do like this.
Meanwhile, I found it seems your patch has not checked in, so if I
don't do these changes, vti will go on block. If my patch checked in xen-devel,
I'm afraid you may need modify setup_guest() in xc_linux_build.c. I'm sorry for
the inconvenience.
Good good study,day day up ! ^_^
-Wing(zhang xin)
OTC,Intel Corporation
>-----Original Message-----
>From: Isaku Yamahata [mailto:yamahata@xxxxxxxxxxxxx]
>Sent: 2006年12月4日 10:22
>To: Zhang, Xing Z
>Cc: Alex Williamson; xen-ia64-devel
>Subject: Re: [Xen-ia64-devel][PATCH]fix vti inital broken after merge
>
>On Fri, Dec 01, 2006 at 10:43:47AM -0700, Alex Williamson wrote:
>
>> > diff -r edaf70bb5bcc xen/common/memory.c
>> > --- a/xen/common/memory.c Thu Nov 30 02:58:43 2006 +0800
>> > +++ b/xen/common/memory.c Fri Dec 01 02:30:19 2006 +0800
>> > @@ -137,6 +137,10 @@ static void populate_physmap(struct memo
>> > {
>> > for ( j = 0; j < (1 << a->extent_order); j++ )
>> > guest_physmap_add_page(d, gpfn + j, mfn + j);
>> > +
>> > + /* Inform the domain of the new page's machine address.
>> > */
>> > + if ( unlikely(__copy_to_guest_offset(a->extent_list, i,
>> > &mfn, 1)) )
>> > + goto out;
>> > }
>> > else
>> > {
>>
>> This chunk will need to be submitted to xen-devel. Thanks,
>
>The foreign domain page mapping semantic of auto translated mode domain
>was changed on x86.
>The above patch of
>http://lists.xensource.com/archives/html/xen-ia64-devel/2006-11/msg00360.ht
>ml
>catches it up on IA64.
>This chunk will be unnecessary with it
>
>--
>yamahata
_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel
|
Home