WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

RE: [Xen-ia64-devel][PATCH] Fix a bug related to vcpu migration

To: "Isaku Yamahata" <yamahata@xxxxxxxxxxxxx>
Subject: RE: [Xen-ia64-devel][PATCH] Fix a bug related to vcpu migration
From: "Xu, Anthony" <anthony.xu@xxxxxxxxx>
Date: Thu, 21 Sep 2006 11:22:27 +0800
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 20 Sep 2006 20:24:39 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcbdI8aw+RRNyTL1ThmYl0XfJpKKTgACC4qA
Thread-topic: [Xen-ia64-devel][PATCH] Fix a bug related to vcpu migration
>From: Isaku Yamahata [mailto:yamahata@xxxxxxxxxxxxx]
>Sent: 2006年9月21日 10:14
>To: Xu, Anthony
>Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
>Subject: Re: [Xen-ia64-devel][PATCH] Fix a bug related to vcpu migration
>
>
>On Thu, Sep 21, 2006 at 09:49:01AM +0800, Xu, Anthony wrote:
>> When destroying domain, only LPs, this domain is running on, do local
>> TLB purge,
>> Other LPs may still have TLBs belonging to this domain,
>> When another domain is created, this may have the same region ID range
>> with old domain,
>> and may conflict with old TLB belonging to old domain.
>> I did observe this scenario, after destroying&creating domain several
>> times,
>> Domain crashing happens.
>>
>> This patch is intended to resolve this issue.
>> Just before launching a VCPU on a LP, Xen purges local TLB on this LP.
>
>Hi Anthony.
>domain_flush_tlb_vhpt() called by arch_domain_destroy()
>addresses this scneario.
>I don't think the patch resolves the domain crash issue because it
>flushes TLB before region ID range is reused.
Yes, you are right, domain_flush_tlb_vhpt() can addresses this scenario.
One comment about flush_tlb_vhpt_all,

static void flush_tlb_vhpt_all (struct domain *d)
{
        /* First VHPT.  */
>>>> if d is not VMX domain
        vhpt_flush ();

        /* Then mTLB.  */
        local_flush_tlb_all ();
}

>
>Have you observed domain crash with the patch?
>If the domain crash disappeared with your patch,
>we might have different issues, I guess.
Before this patch, both dom0 and VTI domain hang after several create&destroy.
After this patch, both dom0 and VTI domain are alive after more than one 
hundred create&destroy.
Seems this issue is related with TLB, I'll continue to debug this.


Thanks,
Anthony



>
>--
>yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>