| |
|
 |
|
 |
|
|
|
| |
|
|
xen-ia64-devel
[Xen-ia64-devel] Re: PATCH: save & restore
Hi Tristan,
Generally looks very good, and it works on my system too! How much
more is required for SMP support? I tried saving a 2-way domU.
Unfortunately it restored with only a single CPU and wasn't very happy
about it. A couple trivial comments below. Thanks,
Alex
On Thu, 2006-07-06 at 15:30 +0200, Tristan Gingold wrote:
> --- a/linux-2.6-xen-sparse/drivers/xen/core/reboot.c Thu Jul 06
> 10:05:14 2006 +0200
> +++ b/linux-2.6-xen-sparse/drivers/xen/core/reboot.c Thu Jul 06
> 13:49:36 2006 +0200
> @@ -39,6 +39,7 @@ extern void ctrl_alt_del(void);
> */
> #define SHUTDOWN_HALT 4
>
> +#ifdef CONFIG_X86
I looks like
#if defined(__i386__) || defined(__x86_64__)
would be more consistent with the rest of the #ifdefs in the file, or is
there some other reason for choosing CONFIG_X86. Note that the #ifdef
around pm_power_off should be addressed if that whole function is
already in an #ifdef.
> +#ifdef CONFIG_X86
> mm_pin_all();
>
> __cli();
> +#endif
> +#ifdef __ia64__
> + local_irq_disable();
> +#endif
Would #else or #elif defined(__ia64__) be more appropriate?
> --- a/tools/libxc/Makefile Thu Jul 06 10:05:14 2006 +0200
> +++ b/tools/libxc/Makefile Thu Jul 06 13:49:36 2006 +0200
> @@ -31,6 +31,8 @@ GUEST_SRCS-y += xc_load_elf.c
> GUEST_SRCS-y += xc_load_elf.c
> GUEST_SRCS-y += xg_private.c
> GUEST_SRCS-$(CONFIG_IA64) += xc_ia64_stubs.c
> +GUEST_SRCS-$(CONFIG_IA64) += ia64/xc_ia64_linux_save.c
> +GUEST_SRCS-$(CONFIG_IA64) += ia64/xc_ia64_linux_restore.c
> GUEST_SRCS-$(CONFIG_MIGRATE) += xc_linux_restore.c xc_linux_save.c
> GUEST_SRCS-$(CONFIG_HVM) += xc_hvm_build.c
Should we move xc_ia64_stubs.c to that directory too? Maybe a proper
Makefile in the ia64 directory?
--
Alex Williamson HP Open Source & Linux Org.
_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel
|
|
|
| |
|
Home