Re: PATCH: was Re: [Xen-ia64-devel] Re: PATCH: cleanup

[Kouya SHIMURA <kouya@xxxxxxxxxxxxxx>]

Hi Tristan,

Is it really safe to insert ia64_dv_serialize_data() after ia64_set_rr()?
I think they should be ia64_srlz_d();
Thanks,

Kouya 

Tristan Gingold writes:
 > diff -r fbc0e953732e -r 7ceaa73bf8fa xen/arch/ia64/vmx/vmmu.c
 > --- a/xen/arch/ia64/vmx/vmmu.c       Thu Jun 15 10:23:57 2006 -0600
 > +++ b/xen/arch/ia64/vmx/vmmu.c       Fri Jun 16 08:49:00 2006 +0200
 > @@ -504,16 +504,18 @@ static void ptc_ga_remote_func (void *va
 >  static void ptc_ga_remote_func (void *varg)
 >  {
 >      u64 oldrid, moldrid;
 > -    VCPU *v;
 >      struct ptc_ga_args *args = (struct ptc_ga_args *)varg;
 > -    v = args->vcpu;
 > +    VCPU *v = args->vcpu;
 > +
 >      oldrid = VMX(v, vrr[0]);
 >      VMX(v, vrr[0]) = args->rid;
 >      moldrid = ia64_get_rr(0x0);
 >      ia64_set_rr(0x0,vrrtomrr(v,args->rid));
 > +    ia64_dv_serialize_data();
 >      vmx_vcpu_ptc_l(v, args->vadr, args->ps);
 >      VMX(v, vrr[0]) = oldrid; 
 >      ia64_set_rr(0x0,moldrid);
 > +    ia64_dv_serialize_data();
 >  }


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel