RE: [Xen-ia64-devel][PATCH] Put guest physical translation intoVHPT

["Xu, Anthony" <anthony.xu@xxxxxxxxx>]

Thanks for your comments.


>-----Original Message-----
>From: Alex Williamson [mailto:alex.williamson@xxxxxx]
>Sent: 2006?6?7? 22:13
>To: Xu, Anthony
>Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
>Subject: Re: [Xen-ia64-devel][PATCH] Put guest physical translation intoVHPT
>
>On Wed, 2006-06-07 at 16:34 +0800, Xu, Anthony wrote:
>> diff -r 4da439f89524 xen/arch/ia64/vmx/vmx_phy_mode.c
>> --- a/xen/arch/ia64/vmx/vmx_phy_mode.c  Wed Jun 07 15:25:31 2006 +0800
>> +++ b/xen/arch/ia64/vmx/vmx_phy_mode.c  Wed Jun 07 16:03:12 2006 +0800
>> @@ -132,6 +132,7 @@ physical_itlb_miss(VCPU *vcpu, u64 vadr)
>>   *      vec=1, itlb miss
>>   *      vec=2, dtlb miss
>>   */
>> + /*
>>  void
>>  physical_tlb_miss(VCPU *vcpu, u64 vadr, u64 vec)
>>  {
>
>Hi Anthony,
>
>  Please don't comment out code like this to disable it.  It's easy to
>miss when reading the code and easy to break by adding a comment to the
>function.  I would prefer that we delete dead code when it's replaced
>(that's what revision control is for), but if you must keep it, at least
>#if it out.  If you could include removal of the commented out function
>right above this addition in your next patch, I'd appreciate it.
>Thanks,
>
>       Alex
>
>--
>Alex Williamson                             HP Open Source & Linux Org.

physical_vhpt_new.patch
Description: physical_vhpt_new.patch

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel