Re: [Xen-ia64-devel] [PATCH] add SATA support in x86_64 and fix

Hi Dan,

Daniel Miles wrote:  [Mon May 22 2006, 07:47:16PM EDT]
> -# CONFIG_BLK_DEV_IDE_SATA is not set
> -# CONFIG_BLK_DEV_HD_IDE is not set
> +CONFIG_BLK_DEV_IDE_SATA=y
> +CONFIG_BLK_DEV_HD_IDE=y

Are you sure this is what you want?  BLK_DEV_IDE_SATA is deprecated in
favor of libsata.  (Search for SCSI_SATA in menuconfig to see what I'm
referring to.)

> +        #main.py has good error messages that let the user know what failed.
> +        #unless the error is a create.py specific thing, it should be handled
> +        #at main. The purpose of this general-case 'Exception' handler is to
> +        #clean up create.py specific processes/data but since create.py does
> +        #not know what to do with the error, it should pass it up.

Style request: could you put a space between the comment marker (#)
and the comment?

Aron

pgpShH950zaLw.pgp
Description: PGP signature

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

Re: [Xen-ia64-devel] [PATCH] add SATA support in x86_64 and fix error handling in xm create, Alex Williamson

Next by Date:

Re: [Xen-ia64-devel] fedora-xen-ia64 first pass, Akio Takebe

Previous by Thread:

Re: [Xen-ia64-devel] [PATCH] add SATA support in x86_64 and fix error handling in xm create, Daniel Miles

Next by Thread:

[Xen-ia64-devel] About oom-killer bug, Zhang, Xiantao

Indexes:

[Date] [Thread] [Top] [All Lists]