WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [PATCH 2/2] FPSWA emulation support

To: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-ia64-devel] [PATCH 2/2] FPSWA emulation support
From: Tristan Gingold <Tristan.Gingold@xxxxxxxx>
Date: Thu, 18 May 2006 13:09:18 +0200
Delivery-date: Thu, 18 May 2006 04:05:09 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <5EC67A66F9768Fkanno.masaki@xxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <5EC67A66F9768Fkanno.masaki@xxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.5
Le Jeudi 18 Mai 2006 12:36, Masaki Kanno a écrit :
> [2/2]

diff -r d2f6e3d70f22 xen/arch/ia64/xen/hypercall.c
--- a/xen/arch/ia64/xen/hypercall.c     Wed May 17 16:31:46 2006 -0600
+++ b/xen/arch/ia64/xen/hypercall.c     Thu May 18 12:43:02 2006 +0900
[...]
+static fpswa_ret_t
+fw_hypercall_fpswa (struct vcpu *v)
+{
+       return ((fpswa_ret_t) {PSCBX(v, fpswa_ret.status),
+                               PSCBX(v, fpswa_ret.err0),
+                               PSCBX(v, fpswa_ret.err1),
+                               PSCBX(v, fpswa_ret.err2)});
+}
Why not return PSCBX(v, fpswa_ret) ?
Avoid this function.

@@ -61,6 +62,7 @@ struct arch_domain {
     char *cmdline;
     int efi_virt_mode;         /* phys : 0 , virt : 1 */
     void *efi_runtime;
+    void *fpswa_inf;
 };
Comments for efi_runtime and fpswa_inf are welcome!

Thank you for this work,
Tristan.

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>