Re: [Xen-devel] PATCH: fix transparent virtualization issue

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 17 May 2006, at 12:17, Tristan Gingold wrote:

> this patch fixes a few transparent virtualization (ie running 
> xenolinux on
> bare platform) issues for xen/ia64.
Why not call xen_init() in the two places you added NULL check for 
xen_start_info? Especially in netfront -- you already call xen_init() 
in blkfront, so it seems weird not to do so in netfront. I see no 
reason not to call it in swiotlb.c too.
xen_init() is a pretty bad name by the way, seeing as it's called all 
over the place so it's not really initialising xen state at every call 
site. Given that it is used in most places for the caller to determine 
if you are running on Xen or not, why not call it running_on_xen() and 
have the initialisation on the first call just be a hidden side effect?
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel