RE: [Xen-ia64-devel] PATCH: cache flush

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

>From: Tristan Gingold
>Sent: 2006年3月31日 23:28
>To: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx; Magenheimer, Dan (HP Labs
>Fort Collins); Alex Williamson
>Subject: [Xen-ia64-devel] PATCH: cache flush
>
>Hi,
>
>this implements sal_cache_flush using fc/fc.i
>
>Tested by compilation + boot+halt of dom0+domU with SMP-g.
>
>Tristan.

One small question. Why do you check upon '4' in sal emulation?

+               /*  The best we can do is to flush with fc all the domain.  */
+               domain_cache_flush (current->domain, in1 == 4 ? 1 : 0);
+               status = 0;

Is it the parameter pass convention? From the SAL spec, 1 for instruction 
cache, 2 for data cache and 3 for both. Seems I missed something here.

You may also want to add similar emulation for PAL_CACHE_FLUSH, 
though it won't be hit especially after applying Alex's patch. But it never 
hurts to add for safety. :-)

Thanks,
Kevin

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel