WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

RE: [Xen-ia64-devel] vcpu_match_tr_entry

To: "Tristan Gingold" <Tristan.Gingold@xxxxxxxx>, <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-ia64-devel] vcpu_match_tr_entry
From: "Xu, Anthony" <anthony.xu@xxxxxxxxx>
Date: Thu, 30 Mar 2006 16:29:39 +0800
Delivery-date: Thu, 30 Mar 2006 08:32:36 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcZT0wxS1ZGI8dluRGSX2ljQSi2RvgAAC9VA
Thread-topic: [Xen-ia64-devel] vcpu_match_tr_entry
>current definition of vcpu_match_tr_entry is:
>#define vcpu_match_tr_entry(_trp,_ifa,_rid)             \
>    ((_trp->p && (_trp->rid==_rid) && (_ifa >= _trp->vadr) &&   \
>    (_ifa < (_trp->vadr + (1L<< _trp->ps)) - 1)))
>                                                          ^^
>Why -1 ?
>I suppose it is either <= (vadr + ps -1) or < (vadr + ps - 1) ?
>
>Thank you for any comment.
Percpu data of guest is put at high address, saying 0xffffffffffff0000,
Thus, vadr+1L<<ps is wrapped to 0, the correct statement maybe,
(_ifa <= (_trp->vadr + (1L<< _trp->ps)) - 1))

Thanks,
Anthony

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>